Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimir build image: Update Go version to 1.23.5 #10481

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

alexander-akhmetov
Copy link
Contributor

This PR updates the Go version used in mimir-build-image to 1.23.5.

Copy link
Contributor

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr10481-6c395eeace. This can take up to 1 hour.

@alexander-akhmetov alexander-akhmetov marked this pull request as ready for review January 20, 2025 12:56
@alexander-akhmetov alexander-akhmetov requested a review from a team as a code owner January 20, 2025 12:56
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aknuds1
Copy link
Contributor

aknuds1 commented Jan 20, 2025

I think you need to amend your latest commit and force push, to trigger CI again after the build image got updated.

@alexander-akhmetov alexander-akhmetov force-pushed the alexander-akhmetov/mimir-build-image-update-go-1.23.5 branch from 493fd98 to 032eac9 Compare January 20, 2025 13:14
Copy link
Contributor

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr10481-6c395eeace already exists.

@alexander-akhmetov
Copy link
Contributor Author

Updated, thanks!

@aknuds1 aknuds1 merged commit fe1d711 into main Jan 20, 2025
29 checks passed
@aknuds1 aknuds1 deleted the alexander-akhmetov/mimir-build-image-update-go-1.23.5 branch January 20, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants