ruler: add "user" and "reason" labels to ruler's queries metrics #10536
+128
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x_ruler_queries metrics Signed-off-by: Vladimir Varankin <[email protected]>
narqo
force-pushed
the
vldmr/ruler-metrics-labels
branch
from
83d36f9 to
47b0bc6
Compare
Signed-off-by: Vladimir Varankin <[email protected]>
narqo
changed the title
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
| @@ -452,7 +452,8 @@ spec: | |||
| runbook_url: https://grafana.com/docs/mimir/latest/operators-guide/mimir-runbooks/#mimirrulertoomanyfailedpushes | |||
| expr: | | |||
| 100 * ( | |||
| sum by (cluster, namespace, pod) (rate(cortex_ruler_write_requests_failed_total[1m])) | |||
| # Here it matches on empty "reason" for backwards compatibility, with when the metric didn't have this label. | |||
| sum by (cluster, namespace, pod) (rate(cortex_ruler_write_requests_failed_total{reason=~"(error|$^)"}[1m])) | |||
There was a problem hiding this comment.
the regex matches EndStart instead of StartEnd is this what you intended?
| }) | ||
| failedWrites := promauto.With(reg).NewCounter(prometheus.CounterOpts{ | ||
| }, []string{"user"}) | ||
| failedWrites := promauto.With(reg).NewCounterVec(prometheus.CounterOpts{ |
There was a problem hiding this comment.
don't forget to make this change in GEM's codebase too
There was a problem hiding this comment.
Oh. I didn't know there is an override. I will open a PR with the update there right after merging this one.
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In this PR I'm adding the
userandreasonlabels to thecortex_ruler_queries_failed_totalandcortex_ruler_write_requests_failed_totalmetrics. The idea behind the change is to allow tenants segregate and track separately the failures, that happened due to issues on the server vs. those happened due to issues on the client-side (e.g. bad rule).The exact list of "reasons" is up for a discussion. I've noticed that Loki uses
errorandupstream_error(code). I'm not sure if those are well translated into what we want. Opinions are welcome.For now, I've chosen to have only two reasons:
errorfor everything4xxfor the case when there is a client-side error in the remote-querier — I think, this will create the most value to start with. I think, we can expand/change the groups in the future. What do you think?Note, for consistency, I also added the
userlabels tocortex_ruler_write_requests_totalandcortex_ruler_queries_total.TODO
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.