Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom webpack #1403

Closed
wants to merge 3 commits into from
Closed

Custom webpack #1403

wants to merge 3 commits into from

Conversation

idastambuk
Copy link

@idastambuk idastambuk commented Dec 12, 2024

What this PR does / why we need it:
Hey all, I ran create-plugin update in one of our plugins that had a webpack.config.ts in its root with some plugin-specific loaders. The script overwrote them to use the ./config/webpack.config.ts, which made some build steps in the CI fail.
I'm not sure if this is the best way to do it, but I tried to add a check that, if the plugin already has a webpack.config.ts file, it will use that file in build and dev scripts.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@idastambuk idastambuk requested a review from a team as a code owner December 12, 2024 11:29
@idastambuk idastambuk requested a review from mckn December 12, 2024 11:29
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

github-actions bot commented Dec 12, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged but will not trigger a new release. To trigger a new release add the release label before merging.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@idastambuk idastambuk added the patch Increment the patch version when merged label Dec 12, 2024
@jackw
Copy link
Collaborator

jackw commented Dec 13, 2024

@idastambuk we really appreciate you looking into a fix for this. It's a known issue that was reported here. However due to how the update command currently operates and, as you've witnessed, breaks things in multiple ways we've decided to rewrite it so it's smarter when it comes to making changes.

Given we already have a way forward that be implemented soon and will solve this issue (along with the others listed in the epic) I'm going to go ahead and close this.

@jackw jackw closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
Development

Successfully merging this pull request may close these issues.

3 participants