Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Plugin: Extend the docker-compose file #1485

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

oshirohugo
Copy link
Contributor

What this PR does / why we need it:

This PR moves the current docker-compose.yaml content to .config/docker-compose-base.yaml and created a new docker-compose.yaml that only extends the one from ./config this will allow us to easily update the docker environment.

The documentation is also updated to reflect the changes.

Which issue(s) this PR fixes:

Fixes #1365

Special notes for your reviewer:

The documentation explaining the docker-compose configs for the debug environment where removed together with the explanation on how to control the go version because in the current state of our docker environment there is no how to control the go-version.

@oshirohugo oshirohugo requested a review from a team as a code owner January 27, 2025 11:26
@oshirohugo oshirohugo requested a review from academo January 27, 2025 11:26
@oshirohugo oshirohugo self-assigned this Jan 27, 2025
@oshirohugo oshirohugo added the create-plugin related to the create-plugin tool label Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged but will not trigger a new release. To trigger a new release add the release label before merging.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@oshirohugo oshirohugo added minor Increment the minor version when merged enhancement New feature or request labels Jan 27, 2025
@oshirohugo oshirohugo requested a review from jackw January 27, 2025 13:06
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@oshirohugo oshirohugo merged commit d12e2ba into main Jan 28, 2025
15 checks passed
@oshirohugo oshirohugo deleted the extend-docker-compose-file branch January 28, 2025 12:53
@grafana-plugins-platform-bot
Copy link

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool enhancement New feature or request minor Increment the minor version when merged released This issue/pull request has been released.
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

Feat: Extend the docker-compose file
2 participants