Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unbalanced pairs in log. #154

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix unbalanced pairs in log. #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfb8159
Fix unbalanced pairs in log.
seizethedave Jun 13, 2024
7cfd9b8
changelog
seizethedave Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* [ENHANCEMENT] Include unique IDs of webhook requests in logs for easier debugging. #150
* [ENHANCEMENT] Include k8s operation username in request debug logs. #152
* [ENHANCEMENT] `rollout-max-unavailable` annotation can now be specified as percentage, e.g.: `rollout-max-unavailable: 25%`. Resulting value is computed as `floor(replicas * percentage)`, but is never less than 1. #153
* [BUGFIX] Fix a mangled error log in controller's delayed downscale code. #154

## v0.16.0

Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/delay.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ func callPrepareDownscaleAndReturnMaxPrepareTimestamp(ctx context.Context, logge

resp, err := client.Do(req)
if err != nil {
level.Error(epLogger).Log("error sending HTTP POST request to endpoint", "err", err)
level.Error(epLogger).Log("msg", "error sending HTTP POST request to endpoint", "err", err)
return err
}

Expand Down