separate statefulset name and statefulset service name in downscaling #173
+122
−94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the rollout-operator was not calling the right pod endpoint with our mimir installation but was calling
mimir-ingester-zone-c-1.mimir-ingester-zone-c.mimir.svc.cluster.local
when it should be using the headless service atmimir-ingester-zone-c-1.mimir-ingester-headless.mimir.svc.cluster.local
This led me to issue #125 so checked on our statefulsets and found the serviceName was correctly set to
serviceName: mimir-ingester-headless
so I dug around a bit and found that the operator was using the an arg named serviceName in
createPrepareDownscaleEndpoints
but passing it the statefulset name.So I've split them to use both the statefulsets name and it's serviceName so that hopefully these requests go to the correct pods
Let me know if this needs changing or if there is another approach that I've missed?