Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate statefulset name and statefulset service name in downscaling #173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fitz7
Copy link

@fitz7 fitz7 commented Sep 26, 2024

I found that the rollout-operator was not calling the right pod endpoint with our mimir installation but was calling mimir-ingester-zone-c-1.mimir-ingester-zone-c.mimir.svc.cluster.local when it should be using the headless service at mimir-ingester-zone-c-1.mimir-ingester-headless.mimir.svc.cluster.local

This led me to issue #125 so checked on our statefulsets and found the serviceName was correctly set to serviceName: mimir-ingester-headless

so I dug around a bit and found that the operator was using the an arg named serviceName in createPrepareDownscaleEndpoints but passing it the statefulset name.

So I've split them to use both the statefulsets name and it's serviceName so that hopefully these requests go to the correct pods

Let me know if this needs changing or if there is another approach that I've missed?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants