Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct rule for AWS product names #1009

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Correct rule for AWS product names #1009

merged 1 commit into from
Jan 28, 2025

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Jan 27, 2025 •
edited
Loading

They don't also require the Amazon prefix in the first instance

Closes #1008

  • I've used a relevant pull request (PR) title.
  • I've added a link to any relevant issues in the PR description.
  • I've checked my changes on the deploy preview and they look good.
  • I've added an entry to the What's new page (only required for notable changes).

@jdbaldry
Correct rule for AWS product names
f2b659c 
They don't also require the Amazon prefix in the first instance

Signed-off-by: Jack Baldry <[email protected]>
@jdbaldry jdbaldry requested review from clayton-cornell and a team as code owners January 27, 2025 12:47
@jdbaldry jdbaldry merged commit 7e9a5cf into main Jan 28, 2025
6 checks passed
@jdbaldry jdbaldry deleted the jdb/2025-01-aws-x-ray branch January 28, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayton-cornell clayton-cornell clayton-cornell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grafana.AmazonProductNames : AWS X-Ray
2 participants
@jdbaldry @clayton-cornell