Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add CMS to Headings yml file #923

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

imatwawana
Copy link
Contributor

No description provided.

@imatwawana imatwawana added the type/docs Docs Squad label used across all Grafana Labs repos label Dec 11, 2024
@imatwawana imatwawana self-assigned this Dec 11, 2024
@imatwawana imatwawana requested review from clayton-cornell and a team as code owners December 11, 2024 20:22
@imatwawana imatwawana merged commit 721cc32 into main Dec 11, 2024
7 checks passed
@imatwawana imatwawana deleted the ihm/111224-update-headings-yaml branch December 11, 2024 20:26
@jdbaldry
Copy link
Member

I need to add some CI checks but this file is generated from the dictionary so this will get overwritten on future dictionary updates.

@clayton-cornell
Copy link
Contributor

The docs here: https://grafana.com/docs/writers-toolkit/review/lint-prose/rules/#grafanaheadings say you can add spelling exceptions to the Headings.yml so this PR looked OK according to that information.

@imatwawana
Copy link
Contributor Author

What @clayton-cornell said

@jdbaldry
Copy link
Member

The docs here: grafana.com/docs/writers-toolkit/review/lint-prose/rules#grafanaheadings say you can add spelling exceptions to the Headings.yml so this PR looked OK according to that information.

I'll need to update that too, thanks for highlighting it :)

@imatwawana
Copy link
Contributor Author

imatwawana commented Dec 13, 2024

@jdbaldry So do I need to update this file as well then:
https://github.com/grafana/writers-toolkit/tree/main/vale/dictionary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label used across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants