Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds landing page instructions #929

Merged
merged 51 commits into from
Dec 20, 2024
Merged

Adds landing page instructions #929

merged 51 commits into from
Dec 20, 2024

Conversation

brendamuir
Copy link
Collaborator

adds landing page instructions to the toolkit

docs/sources/structure/topic-types/landing-page/index.md Outdated Show resolved Hide resolved
docs/sources/structure/topic-types/landing-page/index.md Outdated Show resolved Hide resolved
docs/sources/structure/topic-types/landing-page/index.md Outdated Show resolved Hide resolved
docs/sources/structure/topic-types/landing-page/index.md Outdated Show resolved Hide resolved
docs/sources/structure/topic-types/landing-page/index.md Outdated Show resolved Hide resolved
docs/sources/structure/topic-types/landing-page/index.md Outdated Show resolved Hide resolved
docs/sources/structure/topic-types/landing-page/index.md Outdated Show resolved Hide resolved
docs/sources/structure/topic-types/landing-page/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 18, 2024

💻 Deploy preview deleted.

Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick look at the front matter

docs/sources/structure/topic-types/landing-page/index.md Outdated Show resolved Hide resolved
docs/sources/structure/topic-types/landing-page/index.md Outdated Show resolved Hide resolved
docs/sources/structure/topic-types/landing-page/index.md Outdated Show resolved Hide resolved
brendamuir and others added 6 commits December 18, 2024 13:12
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
brendamuir and others added 3 commits December 20, 2024 11:33
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Jack Baldry <[email protected]>
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the syntax for both of the snippets was not right, can you confirm my suggestions are correct?

docs/sources/structure/topic-types/landing-page/index.md Outdated Show resolved Hide resolved
docs/sources/structure/topic-types/landing-page/index.md Outdated Show resolved Hide resolved
Signed-off-by: Jack Baldry <[email protected]>
@brendamuir
Copy link
Collaborator Author

hi @JStickler can you re-review for me to check if the instructions make more sense now? thanks!

@brendamuir brendamuir merged commit 72c6c25 into main Dec 20, 2024
8 checks passed
@brendamuir brendamuir deleted the add-landing-page branch December 20, 2024 17:11
brendamuir added a commit that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants