-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace individual inputs with JSON string array of inputs #938
Draft
jdbaldry
wants to merge
14
commits into
main
Choose a base branch
from
jdb/2025-01-multiple-source-deploy-preview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdbaldry
force-pushed
the
jdb/2025-01-multiple-source-deploy-preview
branch
3 times, most recently
from
January 13, 2025 12:03
f76cfde
to
d496b20
Compare
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
…ts.*.deprecationMessage Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
jdbaldry
force-pushed
the
jdb/2025-01-multiple-source-deploy-preview
branch
from
January 13, 2025 12:05
d496b20
to
472f155
Compare
Signed-off-by: Jack Baldry <[email protected]>
jdbaldry
force-pushed
the
jdb/2025-01-multiple-source-deploy-preview
branch
from
January 13, 2025 12:06
472f155
to
8a13f2c
Compare
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
jdbaldry
force-pushed
the
jdb/2025-01-multiple-source-deploy-preview
branch
from
January 13, 2025 13:26
94a9c79
to
2fb5410
Compare
Signed-off-by: Jack Baldry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will want to come with a v2 release of the workflow given the breaking changes to the inputs.
I've also shifted the responsibility to check out the repository the caller so that we don't have to manage that ourselves.
I think this is most flexible as it lets the caller organize the workspace using as many repositories as they need (perhaps even using other repositories,
like grafana/enterprise-logs
alongsidegrafana/loki
).The action tries to be self-documenting.
I've been testing this out locally with the following command run from the root of the
grafana/mimir
repository:SOURCES='[{"index_file": "content/docs/mimir/_index.md", "relative_prefix": "/docs/mimir/latest/", "source_directory": "docs/sources/mimir", "website_directory": "content/docs/mimir/latest"}, {"index_file": "content/docs/helm-charts/mimir-distributed/_index.md", "relative_prefix": "/docs/helm-charts/mimir-distributed/latest/", "source_directory": "docs/sources/helm-charts/mimir-distributed", "website_directory": "content/docs/helm-charts/mimir-distributed/latest"}]' "../writers-toolkit/deploy-preview/build.sh"
Signed-off-by: Jack Baldry [email protected]