Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace individual inputs with JSON string array of inputs #938

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Jan 6, 2025

This will want to come with a v2 release of the workflow given the breaking changes to the inputs.
I've also shifted the responsibility to check out the repository the caller so that we don't have to manage that ourselves.
I think this is most flexible as it lets the caller organize the workspace using as many repositories as they need (perhaps even using other repositories, like grafana/enterprise-logs alongside grafana/loki).

The action tries to be self-documenting.

I've been testing this out locally with the following command run from the root of the grafana/mimir repository:

SOURCES='[{"index_file": "content/docs/mimir/_index.md", "relative_prefix": "/docs/mimir/latest/", "source_directory": "docs/sources/mimir", "website_directory": "content/docs/mimir/latest"}, {"index_file": "content/docs/helm-charts/mimir-distributed/_index.md", "relative_prefix": "/docs/helm-charts/mimir-distributed/latest/", "source_directory": "docs/sources/helm-charts/mimir-distributed", "website_directory": "content/docs/helm-charts/mimir-distributed/latest"}]' "../writers-toolkit/deploy-preview/build.sh"

Signed-off-by: Jack Baldry [email protected]

  • I've used a relevant pull request (PR) title.
  • I've added a link to any relevant issues in the PR description.
  • I've checked my changes on the deploy preview and they look good.
  • I've added an entry to the What's new page (only required for notable changes).

@jdbaldry jdbaldry force-pushed the jdb/2025-01-multiple-source-deploy-preview branch 3 times, most recently from f76cfde to d496b20 Compare January 13, 2025 12:03
@jdbaldry jdbaldry force-pushed the jdb/2025-01-multiple-source-deploy-preview branch from d496b20 to 472f155 Compare January 13, 2025 12:05
Signed-off-by: Jack Baldry <[email protected]>
@jdbaldry jdbaldry force-pushed the jdb/2025-01-multiple-source-deploy-preview branch from 472f155 to 8a13f2c Compare January 13, 2025 12:06
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
@jdbaldry jdbaldry force-pushed the jdb/2025-01-multiple-source-deploy-preview branch from 94a9c79 to 2fb5410 Compare January 13, 2025 13:26
Signed-off-by: Jack Baldry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant