Quote environment variables to make the action easier to use with filters #950
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Baldry <[email protected]>
|
💻 Deploy preview available: https://deploy-preview-writers-toolkit-950-zb444pucvq-vp.a.run.app/docs/writers-toolkit/ |
jdbaldry
force-pushed
the
jdb/2025-01-make-vale-action-easier-to-use
branch
from
57be2ca to
778504e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
jdbaldry
force-pushed
the
jdb/2025-01-make-vale-action-easier-to-use
branch
from
57673d4 to
c79ebda
Compare
jdbaldry
changed the title
jdbaldry
requested review from
chri2547,
clayton-cornell and
knylander-grafana
as code owners
jdbaldry
force-pushed
the
jdb/2025-01-make-vale-action-easier-to-use
branch
from
79f524b to
c79ebda
Compare
clayton-cornell
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with string filter in https://github.com/grafana/writers-toolkit/actions/runs/12770075660?pr=950 and empty filter in https://github.com/grafana/writers-toolkit/actions/runs/12770308260/job/35594857756?pr=950
Signed-off-by: Jack Baldry [email protected]