feat: more metrics #122
Closed
feat: more metrics #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
reviewed
Dec 14, 2023
| @@ -109,6 +113,8 @@ pub async fn process_ppoi_message( | |||
| messages: Vec<GraphcastMessage<PublicPoiMessage>>, | |||
| callbook: &CallBook, | |||
| ) -> Result<RemoteAttestationsMap, AttestationError> { | |||
| let start_time = Instant::now(); | |||
There was a problem hiding this comment.
would you explore a bit on how to use the metrics generated by the autometrics macro?
There was a problem hiding this comment.
In the interest of time I created an Issue for this, it will take more time since between the version we're using and 1.0.0 there are a fair amount of breaking changes in autometrics-rs.
#125
| let most_attested_poi = sorted_remote_attestations.last().cloned(); | ||
|
|
||
| if let Some(attestation) = &most_attested_poi { | ||
| MAX_STAKE_POI |
There was a problem hiding this comment.
ATTESTED_MAX_STAKE_WEIGHT?
hopeyen
reviewed
Dec 14, 2023
There was a problem hiding this comment.
CACHED_PPOI_MESSAGESis a gauge, Total Message Count is meant to be a running total of all the POI messages that have been processed, more like a counter, this might be instead theRECEIVED_MESSAGES.- Thinking about
Divergence Rate = (DIVERGING_SUBGRAPHS / sum(CACHED_PPOI_MESSAGES)) * 100again, I'm not sure how an user would interpret this number... I think there could be another metric in addition to track a counter of Comparison results labeled with deployment, then show a metrics on the rate ofresults counter / received messages
would you please also post a screenshot of the dashboard?
pete-eiger
force-pushed
the
petko/add-more-metrics
branch
2 times, most recently
from
067b8ab to
5604214
Compare
pete-eiger
force-pushed
the
petko/add-more-metrics
branch
from
5604214 to
4933912
Compare
|
I will reopen this PR or create a new one with the changes when the memory leak is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #83
Metrics updates:
CACHED_PPOI_MESSAGES, I thinkCACHED_PPOI_MESSAGESfor this, with this promql query on Grafanarate(cached_ppoi_messages[ $__rate_interval ])AVERAGE_PROCESSING_TIMEthat tracks the execution time ofprocess_ppoi_messageFREQUENT_SENDERS_COUNTER, which is updated inprocess_ppoi_message, presented in Grafana usingtopk(10, sum(rate(frequent_senders_counter[$__interval])) by (indexer_address))CACHED_PPOI_MESSAGESandDIVERGING_SUBGRAPHSand this query(DIVERGING_SUBGRAPHS / sum(CACHED_PPOI_MESSAGES)) * 100we can display the divergence rateLATEST_MESSAGE_TIMESTAMPwhich also gets updated inprocess_ppoi_messageMAX_STAKE_POIthat gets updated incompare_attestationswhen we get the most attested poi. Still mulling over the name though 🤔Other changes:
grafana.json