Stable order in generated schema's SDL (#1134) #1237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1134, #865
Synopsis
See #1134 for details:
Solution
The solution is based on the #1134 (comment) approach, proposed and implemented by @michael-groble for the
graphql-parser
directly.We ship it without waiting for a
graphql-parser
, and later can switch to the solution provided by thegraphql-parser
out-of-the-box.Additionally
This PR removes the
graphql-parser
Cargo feature ofjuniper
, because it effectively exposed theRootNode::as_parser_document()
method only, hardly overlapping with theschema-language
Cargo feature exposingRootNode::as_schema_language()
method only.Since they're very similar, now it's only the
schema-language
Cargo feature is left, exposing bothRootNode::as_sdl()
andRootNode::as_document()
methods.Checklist