-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building doesn't render on top of highway areas any more #688
Comments
2014-07-02 19:19 GMT+02:00 sb12 [email protected]:
it is desired for buildings, as something is either a highway area or a |
We will be removing the building transparency, and therefore this change was necessary. In general it is desired behaviour, see #623 and https://lists.openstreetmap.org/pipermail/tagging/2014-June/018043.html. But I agree the results for building=roof (first example) and platforms in buildings (second example) might be improved, so I think we can leave this issue open. |
Thanks for the explanation, I somehow didn't find this commit.
Not necessarily. Sometimes a building can cross over a highway area. Example: http://www.openstreetmap.org/#map=19/49.00904/8.40940 (Picture: http://presse.karlsruhe.de/db/stadtzeitung/gemeinderat_sorgenkind_kronenplatz/13073/sz13_11.jpg) Same problem for arcades in regions that are mapped very detailed. Maybe the layer or the covered tag could help with distinguishing between missing multipolygons and overlapping buildings/highways? |
I thought again about this and found a simple solution to this issue: What about having a second half transparent (opacity=0.3 or similar) building layer on top of the highway layer. Example rendering: Note that this only works after removing transparency and adjusting the colors for the main building layer. |
It looks nice but might make the map more complicated and less readable. |
Nice idea, seems to be quite readable. But IMHO it would be probably better with transparency reduced a bit. |
2014-07-03 9:43 GMT+02:00 Mateusz Konieczny [email protected]:
agree that this works nicely here, but it is still a hack and will not work |
I agree for the consideration of the "layer"-Tag. EDIT: Original link to image (http://www.loaditup.de/821249-8u5ftpqg37.html) broken, replaced. |
Thank you for the additional example. |
I also gave similar example here: #685 (comment) |
@dieterdreist a pedestrian area that is partly covered by a building is IMHO a valid situation (just as it would be if it was mapped as a way) |
This also affects the Eiffel tower: http://www.openstreetmap.org/#map=17/48.85740/2.29346 |
Another partly overlapped building. This one is more covered than hidden. I'm pretty sure you can't use a multipolygon here. |
And this is how it looks in real life. |
@Circeus Maybe mapping pedestal as a separate building:part that would be inner part of multipolygon would slightly help. Unfortunately I found no usable data that would allow this. |
FWIW I should mention I don't have local knowledge. I sort of randomly mapped the Plaza a few years ago (IIRC, because I was adding churches from Wikipedia NRHP articles in the area and the Plaza was a poorly tagged mess). |
Even with this proposed change display of roof would be still really bad. |
There are multiple issues here really. One that keeps coming up is that on pedestrian streets/areas there are often buildings, walls, etc and none of these are rendered, often these pedestrian areas will contain notable/famous buildings/landmarks. (I am not sure people have mentioned they are mostly pedestrian areas this is an issue) I would argue that the roof one over other highways (you know the ones with cars, etc) is a different issue and more of noticeable in even more micro-mapping scenarios. Could we do something for pedestrian streets and render these differently? |
Eiffel Tower has been cleverly "hacked" (by not rendering part of the pedestrian area: http://www.openstreetmap.org/relation/4114062), but the problem still exists. Do we need to tweak everything affected or there are some plans to resolve such issues in a more clean and general way? |
The Eiffel tower solution looks nice, but likely breaks routing across the square, so that's not a solution. Now the building changes have been merged, we can start thinking about a change to the stylesheet that solves this issue. |
Interesting case of a floating entrance: The solution is a pedestrian way (with round edge) running right to the entrance: This small way could be retagged as a footway (mapillary image) but still interesting. |
An other example: |
This PR moves highway areas below all linear road types (resolves gravitystorm#3281). In particular, this change has the following effects: * Render highway areas below tunnels (resolves gravitystorm#529). This prevents the current situation where tunnels are invisible if there happens to be a highway area above them. * Render highway areas below line/area barriers, ferry routes, tourism boundaries, cliffs, landuse-overlay, and turning circles. I think these changes are mainly neutral or positive. * Render highway areas below line/area barriers. This is probably the most controversial aspect (but necessary for the other changes). See screenshot below. * This PR is a necessary condition for merging the roads-casing and roads-fill layers (part of gravitystorm#2046), which would greatly simplify our code. * This PR is a necessary condition for rendering buildings above highway area (gravitystorm#688). * Promoting linear highways over areas makes life easier for other data consumers, that already tend to have poor support for highway areas. For example: * Transport and wikipedia do not render road areas * Humanitarian, bicycle, mapbox, streets, OSM bright renders linear roads on top of areas, like in this proposal
Hi, I just wanted to ask whether I can help in this issue maybe? |
This is a hard problem because there are several conflicting goals - as discussed above (specifically in #688 (comment) and #688 (comment) for example). One possible approach to the problem was discussed in #3872. This was neither rejected nor approved and could be re-visited. But it comes with drawbacks. |
Re: #3872 - that option might be more popular if we removed the highway=pedestrian casing or continued to render it below highway area fill. |
Another example of area affected by this issue: https://www.openstreetmap.org/way/686546745#map=19/-27.49722/153.01578 The pedestrian area ( Here is a screenshot of the issue: Noting that the following renderings don't have that issue:
|
Hi, Sorry, it's not clear. Why can't you downgrade "area=yes, highway=pedestrian" and "area=yes, highway=footpath" (or same with multipolygon) to level of "amenity=parking"? This will solve the issue. |
@matthijsmelissen already answered this in #172 (comment). You can read up a more detailed discussion of this idea in #3872. Also note by the way that pedestrian areas on top of buildings are probably similarly common in reality as pedestrian areas underneath buildings or
|
On your examples:
I've mentioned this layering problem in my comment. See point about "7. No support of visualization prioritization for objects with different layer value". Completely agree with you on this, as of now you can't see gardens on top of buildings, swimming pools, parkings( !) and etc. This is also quite a huge issue. But if accepting that areas with assigned "layers" are not visualised accordingly then pedestrian on the roofs shouldn't be visible similarly to roof gardens, roof playing grounds, roof swimming pools, roof parkings and etc. First of all this 'layer tag' visualization question should be a separate topic. The quick fix here might be also quite simple. First visualize everything with "layer=0" (or without 'layer' tag) accordingly to your prioritization schema. Then visualize "layer=1" without prioritization, after "layer=2" without prioritization and etc. If a mapper is using layers then he has enough experience to take into account difficulty of the area that he is plotting. So I can assure that he would assign layers to everything to prevent and fix any possible visualisation issues.
Just to breakdown this topics: we are talking about wiki hierarchy and about carto hierarchy. I think they might be different. For example you are excluding some objects that are plotted by mappers (underground buildings and etc), but they are part of wiki hierachy. This is done because you have your own hierarchy of objects. As I said "highway=pedestrian" can be convereted to parking in carto hierarchy. |
No, it is not, this is the discussion of the idea of moving the rendering of road polygons from within the road layers to before them (which is the same as what you proposed to 'solve' this issue). As i wrote above:
So if you want to pursue this idea again you need to look at the discussion we have had there and try to address the concerns raised. To avoid misunderstanding: 'Road casing' refers to the darker outline we draw around the road fill at higher zoom levels. For consistent results this needs to be drawn below the road fill but correctly ordered according to bridge/tunnel/layer tags to ensure proper display of where there is connectivity in the road system and where there is not. More detailed discussion of this can be found here. |
All I know is in the case of #5050, if in a few hours one is going to City Hall of a population 3,000,000 city, to try to convince them about OpenStreetMap, whereas there will be no chance, there with the mayor and department heads, in the few minutes allowed, to tell them they need to click on alternative layers... to get the tunnel stuck on top of the roof of City Hall out of the way to avoid major embarrassment... So in the few hours before the meeting, in our hotel room, after having tried various combinations of layer= and covered= etc. (per wiki advice) on both objects, one throws up their hands and following what we see above, unfortunately will have to zap the highway tag. And zap the surface=paved tag too! Finally worked! |
Example way: http://www.openstreetmap.org/way/104978884
Other example area: http://www.openstreetmap.org/#map=19/52.52496/13.36941
This happened after the recent style changes a few days ago.
Before buildings and roofs were rendered on top of the highway areas (and highway ways with covered=yes/tunnel=yes) and you could still see the highways because of the building transparency. Now you can't see the buildings anymore when there's a highway area inside.
Is this a wanted behaviour or an error?
The text was updated successfully, but these errors were encountered: