differentiate guidepost from general tourism=information display

[nebulon42]

Ref #1978, #3105.

Adds a guidepost icon on z19 and drops rendering of guidepost nodes before z19.

before z18

after z18

before z19

after z19

[kocio-pl]

If it's Atom, then you can turn it off by disabling Preferences -> Whitespace -> Remove Trailing Whitespace.

[kocio-pl]

Link for testing place:

https://www.openstreetmap.org/#map=19/46.90772/13.53294

[SomeoneElseOSM]

Excellent idea - I'd also suggest handling trail_blaze and route_marker (see taginfo) as well as guidepost since they're even less significant. See here (and the link via the changelog to the repository) for what I went with, but ignore the PNFS and Sustrans markers since they're UK-specific.

[matthijsmelissen]

Could you perhaps first fix the whitespace issues in a separate PR?

[nebulon42]

@matthijsmelissen Done so now in #3197. and @kocio-pl also opened #3200.
@SomeoneElseOSM Definitely worth handling, but better in a separate PR.

[jragusa]

Several guideposts dedicated for hiking in both France and Switzerland (I don't know for other countries but I suppose too) mention a name and even an elevation. Would it be possible to add these features to the icon ?

[kocio-pl]

We have the code to reuse, so it should be possible. However could you show such examples?

[nebulon42]

@jragusa That could be useful, I'll have a look.

[nebulon42]

@kocio-pl Here are some instances in Austria: https://overpass-turbo.eu/s/ymd.

[nebulon42]

Additionally now the name and/or the elevation is displayed:

[kocio-pl]

Sorry, I wanted the photo example and some explanation, not the link to data set. 😄

If I get it right, they show the real elevation they are located at? But what is their name then? Isn't it the same as name and elevation of the peak or saddle for example?

[nebulon42]

The name is usually a place name, but can also be the name of the saddle and/or peak. Elevation is of course the real elevation. The important part here is that both name and elevation are signed on the guidepost as can be seen in e.g. https://wiki.openstreetmap.org/wiki/File:Signpost.jpg.

[kocio-pl]

I see. OK, so I like this solution. After all they won't eclipse peaks or saddles, because they will be rendered very late.

[kocio-pl]

Maybe it would better to make the code more compact and easier to extend with other types, like:

[feature = 'tourism_information'][information != 'guidepost'][zoom >= 17],
[feature = 'tourism_information'][information = 'guidepost'][zoom >= 19] {
  marker-file: url('symbols/information.12.svg');
  [information = 'guidepost'] { marker-file: url('symbols/guidepost.svg') };
  marker-placement: interior;
  marker-fill: @amenity-brown;
  marker-clip: false;
}

[Tomasz-W]

@nebulon42 Do you have plans to take care of rest of tourism=information icons #1978 (comment) and/ or other related issues #304 #324 ? It would be a big progress in tourism-elements rendering in Carto.

[nebulon42]

@kocio-pl I have updated the code to be more DRY.
@Tomasz-W I have no immediate plans, but I'll put it on my list. :)

[kocio-pl]

What's this line for in text-poly-low-zoom layer? I have tested that it works without this code as well on all the zoom levels.

[nebulon42]

Same thing like #3196. :)

[kocio-pl]

Oh, boy, not again... 😄

Did you have a problem without this code or it's just in case? Did you try with updated Docker image (I mean with a new Kosmtik 😄 ).

I'm ready to merge this code without this line any time. Especially since production rendering servers have no such problem and there are no other mid/high zoom features that I'm aware of which need such addition. Would you like to split it, so we could discuss the low zoom mystery separately?

[nebulon42]

I'll do some tests again when I have time.

[matthijsmelissen]

I'm fine with merging this as is.

Thanks @nebulon42 !

[kocio-pl]

What do you think about adding a mysterious code line?

[kocio-pl]

@matthijsmelissen ping?

[matthijsmelissen]

@nebulon42 Can you get it to work without the 'mysterious line' as well? If so, I'd prefer to merge that version.

[nebulon42]

I have removed the line but did not do additional testing.

[kocio-pl]

Thanks, I've tested it and it works.