-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change scree_overlay of scree and shingle to beach_coarse pattern #4054
Conversation
How so?
First of all it is not the same material. Second if your argument is that there is no reason to better emphasise pebble beach the logical step would be to change the pattern for coarse beaches to make it weaker. Apart from that i think your examples show that this does not work well for scree - the pattern is very noisy on larger areas, it does not harmonize well with natural=bare_rock and paths and other features are poorly visible on it. One argument for having a strong pattern for beaches is that it is supposed to be well readable with water as a background color as well. |
I mean it's much more a noisy pattern than a clear pattern such as those used for
Could you please further explain ?
That's another alternative
We can tune it to provide a more adequate rendering and there are already some issues opened about bad rendering of path along
In other hand, it's mean that pebbly beach are better emphasised than shingle and scree although the latter (can) comprise much more larger block than pebbly beach. |
The orchard and allotments patterns work very differently. The scree/shingle pattern is a structure pattern that functions not by the mapper being able to see the individual symbols and their arrangement but by communicating an overall statistical structure. In any case i don't quite understand the point here because your suggestion effectively would make natural=scree much more noisy.
The coarse beach pattern is used for any beaches consisting of coarser material than sand - which is a very wide range of materials. natural=shingle in terms of physical properties has a much more narrow meaning. natural=scree is in terms of physical properties something again completely different. I would not mind differentiating natural=scree and natural=shingle via pattern but it would need to be intuitively understandable to some extent at least. And i don't think this should mean making natural=scree significantly heavier in rendering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jragusa, I appreciate the attempt to simplify this style by removing one pattern. However, it does not appear that the new rendering is an improvement.
The basic assumption is that the pattern is "proportional" to the grain-size (IMO) and the latter is decreasing with the distance from the source. Hence, we should have scree > shingle > beach although large blocks also occur along rivers in relation to flooding. |
@jragusa - would you be interested in designing a new pattern for just |
Related to #3957 (see comment)
Changes proposed in this pull request:
scree_overlay.png
The current pattern of both scree and shingle is crude and there is no reason to better emphasise pebble beach than scree and shingle: they are all made of the same materials.
Test rendering with links to the example places:
natural=scree
https://www.openstreetmap.org/#map=15/46.2032/7.1130
natural=shingle
https://www.openstreetmap.org/#map=17/46.07486/6.72905
comparison between
natural=beach
andnatural=shingle
https://www.openstreetmap.org/#map=16/46.4013/6.5202