-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add titles to properties and methods sections in API Reference #10821
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10821 +/- ##
===========================================
- Coverage 80.74% 80.70% -0.04%
===========================================
Files 465 465
Lines 40547 40547
===========================================
- Hits 32739 32725 -14
- Misses 7808 7822 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
21cc810
to
2a8cdfb
Compare
6f61905
to
fb49e02
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I have a small nit pick.
Description
Add titles to properties and methods sections in API Reference pages as suggested in the mockup: https://www.figma.com/design/8tOPFUmGKoKVVdFBthjJgZ/API-Doc?node-id=36-580&t=OJzTqULmss3N2Irt-0
Deploy preview: https://deploy-preview-10821.docs.greatexpectations.io/docs/reference/api/data_context/AbstractDataContext_class
Screenshots
Before
After
invoke lint
(usesruff format
+ruff check
)For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!