-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] In-app agent request #10836
base: develop
Are you sure you want to change the base?
[DOCS] In-app agent request #10836
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -1,7 +1,7 @@ | |||
--- | |||
title: 'Deploy the GX Agent' | |||
id: deploy_gx_agent | |||
description: Deploy the GX Agent to use GX Cloud features and functionality. | |||
description: Deploy the GX Agent to test locally or enhance security. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: Though not in the plan, I updated the page description because it looked outdated to me. Apologies for scope creep
|
||
Use the information provided here to view your organization ID or create a new access token. This can be helpful if you've forgotten your organization ID or access token, and you need to restart the GX Agent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for reviewers: though not in the plan, I decided to remove this text because it doesn't make as much sense with the tabs in this section removed.
|
||
If you've used GX Cloud previously, you have your access token and organization ID, and you need to restart the GX Agent, see [Deploy the GX Agent](#deploy-the-gx-agent). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for reviewers: though not in the plan, I decided to remove this since this callout makes less sense with the "New GX Cloud account" tab removed. Also it should be intuitive for folks who already have their access token and org id to skip over this section based on the section header alone.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10836 +/- ##
===========================================
- Coverage 80.69% 80.39% -0.30%
===========================================
Files 465 465
Lines 40493 40493
===========================================
- Hits 32676 32555 -121
- Misses 7817 7938 +121 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Resolves https://greatexpectations.atlassian.net/browse/DOC-1019 according to the plan linked in that issue
invoke lint
(usesruff format
+ruff check
)Deploy Preview at https://deploy-preview-10836.docs.greatexpectations.io/docs/cloud/deploy/deploy_gx_agent
@netlify /docs/cloud/deploy/deploy_gx_agent
For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!