-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Remove xfailed test #10843
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
❌ 23 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
ExpectColumnValuesToBeInTypeList
complete result formatdata_source_configs=[DatabricksDatasourceTestConfig()], | ||
data=DATA, | ||
) | ||
def test_success_complete_errors(batch_for_datasource: Batch) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test could be passing by adding INT
to the array, but we already have a "success" test below this for Databricks. It's not clear how this is meant to test "errors". This is the only xfailed test left for the type/type list Expectations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall what the original point here was either, though looks like it's been updated since the test was created. Either way, seems safe to remove.
invoke lint
(usesruff format
+ruff check
)