Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades to corner radius handler to appear on four sides in rectangle #230

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ramu-narasinga
Copy link

This PR has the following changes:

  1. Corner handles appear on four sides
  2. Drag direction to alter corner radius is consistent across four corners, inwards drag increases the corner radius and outwards drag decreases the corner radius.
  3. There is a maximum radii set to Math.min(node.height, node.width)/2, cross references the Figma and also got the hint from one of the comments

Related issue - #222

Videos recording demonstrating this fix:

Screen.Recording.2025-01-13.at.18.48.39.mov
Screen.Recording.2025-01-13.at.18.50.43.mov

Copy link

codesandbox bot commented Jan 13, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 7:06pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
sites ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 7:06pm

Copy link

vercel bot commented Jan 13, 2025

Someone is attempting to deploy a commit to the Grida Team on Vercel.

A member of the Team first needs to authorize it.

@softmarshmallow
Copy link
Member

softmarshmallow commented Jan 14, 2025

Issue remaining - corner radius control points positioning

Screen.Recording.2025-01-14.at.5.21.50.PM.mov

Hi. @ramu-narasinga this indeed was a existing problem, but if you see a quick solution to this behaviour, it be nice to include in this pr.

Or we can first merge, then fix with new issue. Up to you !

P.s no unnecessary code mods, PR itself if clean and beautiful.

@ramu-narasinga
Copy link
Author

@softmarshmallow Good catch there. Since this issue is still related to corner radius, I would include this fix in this same pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants