Connect download all button in filemngr to zip streamer and log. #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel1138
reviewed
Dec 1, 2023
src/Controller/Api/FileManager.php
Outdated
| $dataset = $datasetSubmission->getDataset(); | ||
| $udi = $dataset->getUdi(); | ||
| // Only log if this is downloaded from dataland. We don't log review downloads. | ||
| if ($request->headers->get('referer') and preg_match("/^.*\/data\/$udi$/", $request->headers->get('referer'))) { |
There was a problem hiding this comment.
Make a variable for Referer, it's at least being used twice.
mickel1138
reviewed
Dec 1, 2023
src/Controller/Api/FileManager.php
Outdated
| @@ -323,70 +326,35 @@ public function downloadFile(File $file, Datastore $datastore): Response | |||
| * | |||
| * @return Response | |||
| */ | |||
| public function downloadZipAllFiles(DatasetSubmission $datasetSubmission): Response | |||
| public function downloadZipAllFiles(DatasetSubmission $datasetSubmission, LogActionItemEventDispatcher $logActionItemEventDispatcher, Request $request): Response | |||
There was a problem hiding this comment.
The docblock can be fixed up some. Order, remove unneeded (or add) params. @route should be last.
Also there are no thrown exceptions.
Fixed download all button in file manager So it would show
mickel1138
previously approved these changes
Dec 1, 2023
mickel1138
previously approved these changes
Dec 1, 2023
mickel1138
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hotfix - but we need to discuss "download all" on dataset submission as that is still broke.
Update: it's not an issue on submission because we don't show the button in file mangaer when called from dataset submission. All should be good.