Factory Initializer Objects #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't count on when the Initializer objects will be destroyed, so we can just have SimulationInitializer be a member of Simulation, we need to instantiate it in the main program and let it live for the duration of the program.
For all physics factories, except the reacting flows factory, the physics factory class is now header-only and all the instantiations of the physics factory have been moved to the new PhysicsFactoryInitializer class. The PhysicsFactoryInitializer is then constructed in SimulationInitializer.
I didn't make this one header only, as with the others, at this point because the collision with another branch in-progress would be pretty bad. So will do this temporarily and clean it up once the other branch (updating Antioch interface) is done.
This moves boundary condition-related factory object instantiation to the initializer object, which is then used in the SimulationInitializer. This is for prevention of symbol stripping during static linking.
|
Will merge this afternoon barring any complaints. |
Merged
roystgnr
reviewed
Apr 25, 2017
|
|
||
|
|
||
| GRINS::SimulationInitializer initializer; | ||
|
|
||
| GRINS::SimulationBuilder sim_builder; |
There was a problem hiding this comment.
Could we have SimulationBuilder create a SimulationInitializer? Then we wouldn't need to change so much user code.
There was a problem hiding this comment.
My intent is for SimulationBuilder to go away after properly factorying out Solver, QoI, etc. (goal is to finish that before tomorrow morning). Also, the PR I'm working on right now will hide all this stuff from the user.
|
Runner PR (#486) hides this away, so I'm going ahead and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ala libqueso/queso#508, this creates FactoryInitializer objects that statically instantiate the factory classes so they don't get stripped by static linking. I collected all of them into
SimulationInitializer, which needs to be instantiated beforeSimulation. (A forthcoming PR is going to refactor the GRINSmainto just call a function which does all the setup and run to ease extension by users.) I believe this captures all "properly" factoried objects, which is confirmed by building with--enable-static --disable-sharedat configure time (I also confirmed we actually failed in this case before this PR). We should add a CIVET recipe for this build configuration (#469, #472).