-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derivations for LowMachNavierStokes Jacobians #1
base: master
Are you sure you want to change the base?
Conversation
Instead of a standalone document, could you please add a section to the existing document and use |
Do you want me to create a new part in the document? Because technically, I can split up my doc into multiple parts to fit the chapter structure you have already implemented. |
Made requested changes. Formatting seems to have some issues though. For some reason, it looks like everything get progressively shifted rightward. Can be clearly seen in the energy residual section 9.4 |
Correct. Other "parts" I'm envisioning are input options, solvers, etc. |
Still have that formatting issue... |
c409540
to
2ac7b14
Compare
We can deal with formatting later. Doing a more fine grained pass now. |
\subsection{Mass Equation} | ||
The given P residual: | ||
\begin{equation} | ||
F_p = (-(U \cdot \nabla T) T^{-1} + \nabla \cdot U)\xi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test function should have an index. I like i
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, I would do something like F_{p,i}
to indicate the i
th equation
OK, all the line notes I made in the pressure section also apply to the momentum and energy sections as well. After addressing those, I think we're good. |
Can you check this commit to make sure I have the notation correct? I would rather get it down right before I do the rest of the document. |
For the momentum and energy equations, we have an issue with notation.
I can just use Which would you prefer? |
This. |
So for momentum, I have
Is this okay? I am unsure about the repeated |
The way you have it written, |
Whoops, forgot to add the dirac delta into the
Better? |
Getting there. The momentum equation is a vector equation, so you should have a free index on the vector component appearing in each term. E.g.
So I suggest using |
Closer?
|
5e9ff1d
to
fefa297
Compare
@tradowsk Have you made all the changes you wanted to make here? |
Let me do one more pass through tonight before you merge it, but I think it should be all set. |
Fixed a typo, so I think it is all set now content-wise. The formatting needs some attention though. |
2fe2fe1
to
c153a7f
Compare
…lete preamble from LMNS.tex, and Makefile was removed since LMNS.tex cannot be built on its own; still need to work out formatting issues
…ians being a section
c153a7f
to
b2bb83b
Compare
Created LaTeX document detailing the derivation of the analytical Jacobians for low_mach_navier_stokes.C, merged into GRINS in PR #183. Makefile included
Set up directory structure as well.