fix: clear translation cache if no translation data was found #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We observed missing translations after upgrades/reboots. It seems that the content of the lookup variable (`($memid, 0)`) was an empty array. Grommunio-web did not recover from this situation as it never clears the cache if the lookup table is empty, automatically. A workaround is to clear the cache using `ipcrm -M 0x950412de`, manually This change clears the cache when the lookup variable is empty or the translation is not found. This allows to recover from a broken cache, automatically.
|
In the rpm/deb packages, there is an ipcrm call. But of course, that only applies when upgrading exactly through rpm/deb, so yeah… :-/ |
We observed it twice since the last month and it also seems to happen after rebooting. I'd debugged one of them and the lookup var was just an empty array. I did not find any obvious race condition yet (we have several users who have grommunio-web open all the time, even during maintenance windows), but the change should help to recover. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed missing translations after upgrades/reboots. It seems that the content of the lookup variable (
($memid, 0)) was an empty array. Grommunio-web did not recover from this situation as it never clears the cache if the lookup table is empty, automatically. A workaround is to clear the cache usingipcrm -M 0x950412de, manuallyThis change clears the cache when the lookup variable is empty or the translation is not found. This allows to recover from a broken cache, automatically.