Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First stab at trying to encode video from a directory of Screenshots #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stevejensen22
Copy link

No description provided.

@smccarthy
Copy link
Collaborator

Thanks @stevejensen22 . I will try and take a look at this. I'll probably build it and try it out on my grid at work for a week or so (maybe next week or the week after).

Just a couple quick questions, this feature is on by default in this PR? And if I wanted a video of the entire desktop, I'd use that system property?

Is the only thing new from lines 131 - 165 in this PR, and everything else is the old logic?

Thanks.

@robbiewareham
Copy link

So is the idea to use Selenium screenshots captured at a Browser level, and therefore support multiple videos?

If so, then you should keep in mind that the Selenium screenshot method has to wait for other Selenium methods to finish.

Therefore, if your page was extremely slow to load, your video would not reflect that as Selenium would be blocking until the DOM ready state is achieved. The page would appear to load immediately and be potentially confusing

The O/S level video is going to be a truer reflection of what actually happened

@janwiemers
Copy link

Hi there,

I'm fairly new to selenium grid extras but couldn't one use pageLoad: none as capabilities to skip the waiting for the page to fully load. I use that to inject a small piece of JS at the beginning and it works fairly well.

Best jan

@YogiBear52
Copy link

Os level video is truer than browser level, but Os level video doesn't make sense if the node runs more then one session at a time, which is not true most of the times.
Therefore I think browser video should be configurable. Some would prefer the OS level because it is more reliable, but other who runs more than one session at a time per node would prefer the browser level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants