Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifting of application conditions #45

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

szschaler
Copy link
Member

A first step towards #4. (Replication of prematurely merged #43. Please do not merge this until @szschaler has marked it ready for review.)

@szschaler szschaler self-assigned this Dec 19, 2019
@szschaler szschaler added the enhancement New feature or request label Dec 19, 2019
@szschaler
Copy link
Member Author

Had a discussion with Daniel and Stefan on Henshin users list. They confirm that the intended semantics is the standard AC semantics, but that henshin models may contain partial mappings and partial representations. Thus, I will need to "sanitise" these. In producing ACs from shifting, I should always produce the full graphs and mappings.

I believe, this means that my test is wrong and my implementation is correct. Need to find a cleaner test to validate this understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant