use email-newsletter layout data from frontend #12795
Open
+52
−337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
4 tasks
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
|
This PR was closed because it has been stalled for 3 days with no activity. |
|
Size Change: 0 B Total Size: 894 kB ℹ️ View Unchanged
|
dblatcher
changed the title
…om/guardian/dotcom-rendering into dblatcher-use-layout-from-frontend
JamieB-gu
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Instead of using the hard coded newsletter layouts, the /email-newsletters pages will get the data from the frontend page model (which was derives it from the newsletters API) - see:
One significant behaviour change is that DCR used to fallback to the UK layout if it did not have a layout hard coded for the editionId of the request (as was the case for EUR and INTL) - it would now fallback to the
reduceToDefaultGroupingfunction to arrange the newsletters (which would previously be used if the UK layout was not defined either).On discussing with editorial, they would prefer to define layouts for EUR and INTL, so the data in the newsletters API (see https://newsletters-tool.gutools.co.uk/layouts) has been updated to match the hard coded data (as of the last update: #13248), with the layouts for EUR and INTL being set as copies of the UK data.
Why?
Will allow editorial to self-serve for changes to the page via the newsletters tool. This currently requires WebEx to do a PR for every change requested by editorial. 😢
Testing
CODE frontend uses the PROD newsletter API data, so when running this branch on CODE, the layouts defined at https://newsletters-tool.gutools.co.uk/layouts will be show on /email-newsletter
LOCAL frontend used CODE newsletter API data, so testing this branch with LOCAL frontend would show the layouts from https://newsletters-tool.code.dev-gutools.co.uk/layouts
Screenshots
{"ok":true,"total":1,"data":{"UK":[{"title":"my collection","subtitle":"a set of newsletters","newsletters":["today-uk","front-page","morning-briefing"]},{"title":"In depth","newsletters":["today-uk","afternoon-update","any-time"]}]}}