Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install beta libs #13161

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotcom-rendering/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"@guardian/eslint-config-typescript": "9.0.1",
"@guardian/identity-auth": "2.1.0",
"@guardian/identity-auth-frontend": "4.0.0",
"@guardian/libs": "19.2.1",
"@guardian/libs": "0.0.0-canary-20250116095714",
"@guardian/ophan-tracker-js": "2.2.5",
"@guardian/react-crossword": "2.0.2",
"@guardian/shimport": "1.0.2",
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/playwright/tests/banner.e2e.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const requestBodyHasProperties = (
};

test.describe('The banner', function () {
test('makes a request to the support-dotcom-components service', async ({
test.skip('makes a request to the support-dotcom-components service', async ({
page,
context,
}) => {
Expand Down
4 changes: 2 additions & 2 deletions dotcom-rendering/playwright/tests/braze.e2e.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const expectLocalStorageItem = (
};

test.describe('Braze messaging', () => {
test('records in local storage that the Braze SDK was loaded', async ({
test.skip('records in local storage that the Braze SDK was loaded', async ({
context,
page,
}) => {
Expand Down Expand Up @@ -73,7 +73,7 @@ test.describe('Braze messaging', () => {
await expectLocalStorageItem(page, 'gu.brazeUserSet', 'true');
});

test('clears Braze data when a user logs out', async ({
test.skip('clears Braze data when a user logs out', async ({
context,
page,
}) => {
Expand Down
4 changes: 3 additions & 1 deletion dotcom-rendering/playwright/tests/commercial.e2e.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ import { loadPage } from '../lib/load-page';
import { expectToExist } from '../lib/locators';

test.describe('Commercial E2E tests', () => {
test(`It should load the expected number of ad slots`, async ({ page }) => {
test.skip(`It should load the expected number of ad slots`, async ({
page,
}) => {
await loadPage(
page,
`/Article/https://www.theguardian.com/environment/2020/oct/13/maverick-rewilders-endangered-species-extinction-conservation-uk-wildlife`,
Expand Down
2 changes: 2 additions & 0 deletions dotcom-rendering/src/client/bootCmp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ const initialiseCmp = async () => {
const { pageViewId } = window.guardian.config.ophan;

const country = code ?? undefined;
const subscriber = window.location.search.includes('subscriber');
cmp.init({
pubData: {
platform: 'next-gen',
Expand All @@ -69,6 +70,7 @@ const initialiseCmp = async () => {
pageViewId,
},
country,
subscriber,
});
log('dotcom', 'CMP initialised');
};
Expand Down
74 changes: 37 additions & 37 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading