Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow multiple ingress hostnames #74

Merged
merged 5 commits into from
Feb 18, 2024
Merged

feat: allow multiple ingress hostnames #74

merged 5 commits into from
Feb 18, 2024

Conversation

santiagon610
Copy link
Contributor

This pull request allows users to easily create ingress rules to allow their Vaultwarden instance to use multiple FQDNs.

Key changes:

  • Updated documentation using the provided generate-readme.sh (btw, thank you for that!)
  • In the Ingress template, add two variables for abstraction of the global scope:
    • $websocket, which aliases back to .Values.websocket
    • $fullname, which aliases back to .Release.fullname
  • Implementation of a range around .Values.ingress.additionalHostnames to create:
    • Ingress host records
    • Ingress rule sets
  • On the generate-readme.sh script, add a flag to use a container in privileged mode, as Podman requires that for accessing the local filesystem using the volume mount method provided.

@guerzon guerzon merged commit 5ca9c62 into guerzon:main Feb 18, 2024
1 check passed
@guerzon
Copy link
Owner

guerzon commented Feb 18, 2024

Thanks for the PR @santiagon610!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants