Do not udpate forbidden fields for statefulset #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every time I upgrade this helm chart I got this error
```
Error: UPGRADE FAILED: cannot patch "vaultwarden" with kind StatefulSet: StatefulSet.apps "vaultwarden" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'ordinals', 'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden
```
Lets not put all the labels from helper, because they contain also chart version which changes on every upgrade
```
volumeClaimTemplates:
- metadata:
name: vaultwarden-data
labels:
- helm.sh/chart: vaultwarden-0.20.0
+ helm.sh/chart: vaultwarden-0.22.1
app.kubernetes.io/name: vaultwarden
app.kubernetes.io/instance: vaultwarden
- app.kubernetes.io/version: "1.30.1"
+ app.kubernetes.io/version: "1.30.3"
app.kubernetes.io/managed-by: Helm
```
Fixes: guerzon#58
santiagon610
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
This looks like a simple fix for a problem that's been out there for a while. Well done, @dolohow!
Co-authored-by: Nicholas Santiago <[email protected]>
|
I applied your suggestion. Please when merging, squash commits. Thanks |
|
I'm just another contributor on this repo like yourself, but I believe that @guerzon has the default behavior set to Squash and merge, as was my experience on the PR that I just raised a couple days ago. |
|
Thanks for the PR @dolohow and the input @santiagon610! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time I upgrade this helm chart I got this error
Lets not put all the labels from helper, because they contain also chart version which changes on every upgrade
Fixes: #58