Added prefer_local_executable: true option so that users are able to install chrome-headless-render-pdf and puppeteer locally
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d within the /assets/node_modules directory
|
Hu @ryanzidago , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance, in the context of a Phoenix application, users can now chose if they would rather install
chrome-headless-render-pdfandpuppeteerwithin the/assets/node_modulesdirectory.Having npm packages installed locally makes it easier to deploy an application to Heroku, where it is unrecommended to having them installed globally.
Furthermore, with this
prefer_local_executable, users are not required to do complex manipulation withMakefile, granted that they do not usemix release.The
README.mdwas adapted to include the options, typos were fixed.A test was written to check if the option works as intented.