New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chonk, NodeUtils: Fixed Linux gcc compile bugs #2386

Merged

gwaldron merged 2 commits into gwaldron:master from emminizer:fix-linux

Nov 22, 2023

Contributor

emminizer commented Nov 22, 2023

Fixed compile bugs seen on Linux side:

ChonkDrawable is now forward declared. Previously it was mentioned below in a friend class ChonkDrawable but gcc doesn't treat that the same as a class ChonkDrawable declaration, though MSVC accepts it.
Lambdas are now passed by const reference instead of non-const reference. The Lambda gets copied anyways, so const is fine, and allows for r-values. MSVC also lets you get away without the const but probably shouldn't.

No functionality changes, just compiler fixes.

Daniel Emminizer added 2 commits

November 22, 2023 09:08


          Chonk, NodeUtils: Fixed Linux gcc compile bugs

a8f67d9


          AnnotationsGUI: Fix missing required namespace, fixing external builds.

0b13850

gwaldron merged commit c54ac65 into gwaldron:master

3 checks passed

emminizer deleted the fix-linux branch

April 25, 2024 14:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet