Skip to content

Commit

Permalink
Apply suggestions from @TomF 's code review
Browse files Browse the repository at this point in the history
Co-authored-by: Tomáš Frýda <[email protected]>
  • Loading branch information
sebhrusen and tomasfryda authored Feb 9, 2024
1 parent 50c80df commit c7c5bb4
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 0 additions & 4 deletions h2o-core/src/main/java/hex/pipeline/PipelineHelper.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ public static Frame reassign(Frame fr, Key<Frame> key, Key<Job> job) {
copy._key = key;
copy.write_lock(job);
copy.update(job);
// copy.unlock(job);
return copy;
}

Expand All @@ -33,8 +32,5 @@ public static void reassignInplace(Frame fr, Key<Frame> key, Key<Job> job) {
if (fr.getKey() != null) DKV.remove(fr.getKey());
fr._key = key;
DKV.put(fr);
// fr.write_lock(job);
// fr.update(job);
// fr.unlock(job);
}
}
2 changes: 1 addition & 1 deletion h2o-r/h2o-package/R/classes.R
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,7 @@ setClass("H2OSegmentModels", slots = c(segment_models_id = "character"))

setClass("H2ODataTransformer", slots = c(id = "character", description = "character"))
setClass("H2OPipeline", contains="H2OModel",
slots=c(
slots = c(
transformers = "list",
estimator_model = "H2OModel"
))
Expand Down

0 comments on commit c7c5bb4

Please sign in to comment.