LoggerFactory slf4j related regression fix #15659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the regression that caused DRF loading fail due to spurious dependency on slf4j when log4j2 exists. Check for water logging availability was throwing exception if slf4j was not used while loading some models. this seems like a regression between 3.30 and 3.40. h2oai#6725
yazun
force-pushed
the
LoggerFactory-slf4j-problem
branch
from
6d10f5b to
49cb990
Compare
|
rebased to latest. I am on the road now with no local copy, so it might be done in 2 days or so. |
|
Hello @mn-mikke |
|
Dear @mmalohlava, would you have time to review this change? I work in the academic team with @yazun and currently we have a cumbersome workaround using a custom-build jar file by @yazun , but we would much prefer to migrate to the latest version that has this fix included. Best regards, and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the regression that caused DRF loading fail due to spurious dependency on slf4j when log4j2 exists. Check for water logging availability was throwing exception if slf4j was not used while loading some models. Seems like a regression between 3.30 and 3.40. #6725