Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nocheck] README visible links for communication channels #15874

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[nocheck] README visible links for communication channels #15874

merged 1 commit into from
Oct 26, 2023

Conversation

sebhrusen
Copy link
Contributor

@sebhrusen sebhrusen commented Oct 25, 2023 •
edited
Loading

improve header on README file to encourage users with questions to use the right channels

see result: https://github.com/h2oai/h2o-3/tree/seb/readme-questions

@sebhrusen sebhrusen added the docs label Oct 25, 2023
@sebhrusen sebhrusen added this to the 3.44.0.2 milestone Oct 25, 2023
@sebhrusen sebhrusen self-assigned this Oct 25, 2023
@sebhrusen sebhrusen requested a review from mn-mikke October 25, 2023 20:16
@sebhrusen sebhrusen changed the title README visible links for communication channels [nocheck] README visible links for communication channels Oct 25, 2023
@sebhrusen
Copy link
Contributor Author

@mn-mikke I use nocheck as it's just a change in readme, so not necessary to check tests for this

mn-mikke
mn-mikke approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sebhrusen sebhrusen merged commit 0d6ab63 into rel-3.44.0 Oct 26, 2023
@sebhrusen sebhrusen deleted the seb/readme-questions branch October 26, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mn-mikke mn-mikke mn-mikke approved these changes

@hannah-tillman hannah-tillman Awaiting requested review from hannah-tillman

Assignees

@sebhrusen sebhrusen

Labels
docs
Projects
None yet
Milestone
3.44.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@sebhrusen @mn-mikke