-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-15780 set weak learner parameter api documentation #15920
Merged
valenad1
merged 3 commits into
rel-3.44.0
from
valenad-15780-set-weak-learner-parameter-API-documentation
Nov 22, 2023
Merged
GH-15780 set weak learner parameter api documentation #15920
valenad1
merged 3 commits into
rel-3.44.0
from
valenad-15780-set-weak-learner-parameter-API-documentation
Nov 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurever
previously approved these changes
Nov 17, 2023
valenad1
force-pushed
the
valenad-15780-set-weak-learner-parameter-API-documentation
branch
from
November 21, 2023 15:47
2d01108
to
32a4f82
Compare
valenad1
force-pushed
the
valenad-15780-set-weak-learner-parameter-API
branch
from
November 21, 2023 15:48
f2e33b3
to
73003e8
Compare
@hannah-tillman can you please check the wording? |
valenad1
force-pushed
the
valenad-15780-set-weak-learner-parameter-API
branch
from
November 22, 2023 15:03
7c3daa1
to
c06db92
Compare
valenad1
force-pushed
the
valenad-15780-set-weak-learner-parameter-API-documentation
branch
from
November 22, 2023 15:10
5a14f22
to
5fd2b30
Compare
valenad1
changed the base branch from
valenad-15780-set-weak-learner-parameter-API
to
rel-3.44.0
November 22, 2023 15:11
maurever
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
valenad1
deleted the
valenad-15780-set-weak-learner-parameter-API-documentation
branch
November 22, 2023 17:57
@@ -49,6 +49,10 @@ Algorithm-specific parameters | |||
|
|||
- ``GLM``: Trains a binary classifier with ``max_iterations=50``. | |||
|
|||
- ``DEEP_LEARNING``: Trains a binary classifier with ``(epochs=10, hidden=[2])``. | |||
|
|||
- **weak_learner_params**: With ``weak_learner``, you can also specify a dict/list of customized parameters for that algorithm. For example if we use a ``GBM``, we can specify ``{'ntrees': 1, 'max_depth': 10}`` in Python and ``list(ntrees = 1, max_depth = 10)`` in R. AdaBoost does not apply defaults from the ``weak_learner`` at all. The defaults of the algorithm itself will be used instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- **weak_learner_params**: With ``weak_learner``, you can also specify a dict/list of customized parameters for that algorithm. For example if we use a ``GBM``, we can specify ``{'ntrees': 1, 'max_depth': 10}`` in Python and ``list(ntrees = 1, max_depth = 10)`` in R. AdaBoost does not apply defaults from the ``weak_learner`` at all. The defaults of the algorithm itself will be used instead. | |
- **weak_learner_params**: You can specify a dict/list of customized parameters for your specified ``weak_learner`` algorithm. For example, if you use a ``GBM``, you can specify ``{'ntrees': 1, 'max_depth': 10}`` in Python or ``list(ntrees = 1, max_depth = 10)`` in R. AdaBoost does not apply defaults from the ``weak_learner`` at all. The defaults of the algorithm itself will be used instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15780