Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-15780 set weak learner parameter api documentation #15920

Merged

Conversation

valenad1
Copy link
Collaborator

maurever
maurever previously approved these changes Nov 17, 2023
@valenad1 valenad1 force-pushed the valenad-15780-set-weak-learner-parameter-API-documentation branch from 2d01108 to 32a4f82 Compare November 21, 2023 15:47
@valenad1 valenad1 force-pushed the valenad-15780-set-weak-learner-parameter-API branch from f2e33b3 to 73003e8 Compare November 21, 2023 15:48
@valenad1
Copy link
Collaborator Author

@hannah-tillman can you please check the wording?

@valenad1 valenad1 force-pushed the valenad-15780-set-weak-learner-parameter-API branch from 7c3daa1 to c06db92 Compare November 22, 2023 15:03
@valenad1 valenad1 force-pushed the valenad-15780-set-weak-learner-parameter-API-documentation branch from 5a14f22 to 5fd2b30 Compare November 22, 2023 15:10
@valenad1 valenad1 changed the base branch from valenad-15780-set-weak-learner-parameter-API to rel-3.44.0 November 22, 2023 15:11
@valenad1 valenad1 dismissed maurever’s stale review November 22, 2023 15:11

The base branch was changed.

Copy link
Contributor

@maurever maurever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@valenad1 valenad1 merged commit 97cccbf into rel-3.44.0 Nov 22, 2023
2 checks passed
@valenad1 valenad1 deleted the valenad-15780-set-weak-learner-parameter-API-documentation branch November 22, 2023 17:57
@@ -49,6 +49,10 @@ Algorithm-specific parameters

- ``GLM``: Trains a binary classifier with ``max_iterations=50``.

- ``DEEP_LEARNING``: Trains a binary classifier with ``(epochs=10, hidden=[2])``.

- **weak_learner_params**: With ``weak_learner``, you can also specify a dict/list of customized parameters for that algorithm. For example if we use a ``GBM``, we can specify ``{'ntrees': 1, 'max_depth': 10}`` in Python and ``list(ntrees = 1, max_depth = 10)`` in R. AdaBoost does not apply defaults from the ``weak_learner`` at all. The defaults of the algorithm itself will be used instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **weak_learner_params**: With ``weak_learner``, you can also specify a dict/list of customized parameters for that algorithm. For example if we use a ``GBM``, we can specify ``{'ntrees': 1, 'max_depth': 10}`` in Python and ``list(ntrees = 1, max_depth = 10)`` in R. AdaBoost does not apply defaults from the ``weak_learner`` at all. The defaults of the algorithm itself will be used instead.
- **weak_learner_params**: You can specify a dict/list of customized parameters for your specified ``weak_learner`` algorithm. For example, if you use a ``GBM``, you can specify ``{'ntrees': 1, 'max_depth': 10}`` in Python or ``list(ntrees = 1, max_depth = 10)`` in R. AdaBoost does not apply defaults from the ``weak_learner`` at all. The defaults of the algorithm itself will be used instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants