Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-15677 Fix %in% function #15929

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

maurever
Copy link
Contributor

@maurever maurever commented Nov 17, 2023

Issue: #15677

Fix %in% functionality to work with h2o frame correctly as base::%in%.

@maurever maurever added this to the 3.46.0.1 milestone Nov 17, 2023
@maurever maurever self-assigned this Nov 17, 2023
@maurever maurever mentioned this pull request Nov 17, 2023
6 tasks
wendycwong
wendycwong previously approved these changes Nov 21, 2023
sebhrusen
sebhrusen previously approved these changes Nov 21, 2023
Copy link
Contributor

@sebhrusen sebhrusen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@maurever maurever dismissed stale reviews from sebhrusen and wendycwong via da23c2c November 22, 2023 09:44
@maurever maurever force-pushed the maurever_GH-15677_fix_in_match_function branch from da23c2c to 398e8e7 Compare November 22, 2023 09:56
@maurever
Copy link
Contributor Author

@sebhrusen and @wendycwong , thanks for your reviews. I am sorry, I accidentally pushed a new commit here and then reverted it, so please approve it again. Thanks!

@maurever maurever merged commit 0e5f0ac into master Nov 22, 2023
2 checks passed
@maurever maurever deleted the maurever_GH-15677_fix_in_match_function branch November 22, 2023 14:42
@tomasfryda tomasfryda mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants