Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Craft ModelSelection Examples #15944

Closed
wants to merge 54 commits into from
Closed

Conversation

shaunyogeshwaran
Copy link
Contributor

Crafted new examples for the ModelSelection Algorithm to showcase the different parameters.

h2o-ops and others added 30 commits October 11, 2023 07:56
* [GH-15832] Add "Known Bug" section to release notes

* Use singular form

* ht/broke it up

made it so "known bug" and the note explaining what this new section is aren't on the same line

---------

Co-authored-by: Hannah Tillman <[email protected]>
…15849)

* [GH-15654] Introduce MLFlow flavors for working with mojos and pojos

* First version of mojo flavor by Eric Wolf

* New saving method

* Update loading mojos

* Fix upload mojos.

* Fix building

* Fix h2o_mlflow_flavor

* Update

* Update loader module

* Update h2o_mojo

* Add genmodel flavor

* Fix pojo

* Fix pojo

* Add extraction of metrics

* Fix metric extraction

* add input examples

* moved mlflow-flavor

* Add examples

* Add doc

* Add description.rst

* Update description

* description

* description

* update description

* update description

* update description

* update description

* update description

* update description

* update description

* update description

* update description

* update description

* update description

* update description

* update description

* update description

* update description

* Add flavor as self reference

* Update build definition

* Remove gitignore

* Just one doc

* Revert DRF_mojo.ipynb

---------

Co-authored-by: Eric Wolf <[email protected]>
h2o-ops and others added 5 commits November 23, 2023 21:32
…s from autodeletion (#6335)

* consistent mechanism to protect frames or some of their vecs from auto deletion

* fix from old javadoc

* typo

* having fun: proposing some syntactic sugar

* fixed DeepLearning inconsistent use of Scope + enforce early detection of those inconsistent usages

* protect frame params only on expensive init

* fix GLMTest with inconsistent use of Scope.enter/exit

* for simplicity (and backwards compatibility) ensure Frame's Vecs get deleted by default during explicit delete of tmp Frame

* fixed too memory-lenient test in GBMTest

* improve usage consistency of Scope.(un)track in code+tests

* fixed wrong usage of track_generic(fr) in tests

* fixed key leakage on model interruption/timeout (was detected only by AutoML tests)

* clean up

* fixed LeaderboardTest after switch to H2ORunner

* ensure that workspace cleanup (mainly used during CV) doesn't 'accidentally' delete protected keys

* fixed introduced NPE

* comment

* fixed corner case when tmp Vec are created e.g. for validation frame on CV model, and still needed for CV scoring

* fixed increasing frustration with inconsistent logic in leaked keys checking: may reveal several leakage issues in some tests

* this should make the priority logic more clear

* improve parent job lifecycle in ModelingStepsExecutorTest as it leaked running job keys (detected with new rule)

* fix rules list for tests inheriting TestUtil

* give the possibility to track some context with some keys and use it for now to bulk delete Vecs at Scope.exit

* optimize Vec tracking so that they can also be bulk removed

* fixed newly introduced NPEs

* added test for null checks

* centralized rules priorities + use annotation for clarity+visibility and better understand how rules are ordered

* disable bulk_remove for some indivudally tracked Vecs

* use Scope.safe to replace recent usages of 'unsafe' deleteTempFrameAndItsNonSharedVecs

* fixed test compilation issue

* removed unused code and comments

* fixed some of the introduced key leaks missed during the rebase

* removing tmp key tracking logs

* fixed orphan Scope.exit in ModelSelection

* fixed orphan Shap contributions keys leakage

* fixed xgboost score predictions

* fixed more key leakages

* revert accidental changes on failing Py test

* fixed failing test pyunit_plot_functions__add_saving_parameter_and_decorate_plot_result

* prevent some potential other race condition in PartialDependence

---------

Co-authored-by: Sebastien Poirier <[email protected]>
@wendycwong
Copy link
Contributor

@shaunyogeshwaran : Thank you for working on this. However, I don't think we need an example for every parameters for ModelSelection. In fact, I think the only parameters you want to showcase are those specific to ModelSelection. What do you think?

h2o-ops and others added 14 commits December 6, 2023 21:32
* Add grid search junit test, edit gridable parameters

* Implement python test

* Implement R test
* Implement the user suggestions

* Return sorting, implement mapping of indexes

* Implement a case where match values are not unique

* Improve doc and tests

* Unify R and Python examples

---------

Co-authored-by: Hannah Tillman <[email protected]>
Co-authored-by: seb <[email protected]>
GH-15791 UpliftDRF implement early stopping, add tests

---------

Co-authored-by: Adam Valenta <[email protected]>
This reverts commit 818ead6, reversing
changes made to 589168e.
@shaunyogeshwaran shaunyogeshwaran changed the base branch from master to rel-3.44.0 January 3, 2024 07:37
@shaunyogeshwaran shaunyogeshwaran added this to the 3.44.0.4 milestone Jan 3, 2024
@shaunyogeshwaran shaunyogeshwaran linked an issue Jan 3, 2024 that may be closed by this pull request
@shaunyogeshwaran shaunyogeshwaran deleted the sy/#15915-MS branch January 3, 2024 17:18
@mn-mikke mn-mikke removed this from the 3.44.0.4 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants