Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-7118 - score eif accoring to computing time settings #6039

Merged

Conversation

valenad1
Copy link
Collaborator

@valenad1 valenad1 commented Jan 25, 2022

Score each iteration for first 4s of the run and after each 4s after...

#7118

@valenad1 valenad1 force-pushed the valenad-eif-scoring-history-score-according-computing-time branch 2 times, most recently from 43b6c5b to 724ddd1 Compare January 26, 2022 17:46
@valenad1 valenad1 force-pushed the valenad-eif-scoring-history branch from ef7769e to 3288b7a Compare January 26, 2022 18:35
@valenad1 valenad1 force-pushed the valenad-eif-scoring-history-score-according-computing-time branch from 724ddd1 to d521136 Compare January 26, 2022 18:39
Copy link
Contributor

@maurever maurever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question.

@valenad1 valenad1 force-pushed the valenad-eif-scoring-history-score-according-computing-time branch from 01228fe to 4f06aea Compare March 4, 2022 01:08
@valenad1 valenad1 force-pushed the valenad-eif-scoring-history branch 2 times, most recently from 321eac5 to 25d0f39 Compare March 9, 2022 16:58
@valenad1 valenad1 force-pushed the valenad-eif-scoring-history-score-according-computing-time branch from 4f06aea to eb05635 Compare March 9, 2022 16:59
@valenad1 valenad1 force-pushed the valenad-eif-scoring-history branch from b200341 to e2f32ac Compare October 26, 2023 17:27
@valenad1 valenad1 force-pushed the valenad-eif-scoring-history-score-according-computing-time branch from eb05635 to 52bcfd9 Compare October 26, 2023 17:28
@valenad1 valenad1 force-pushed the valenad-eif-scoring-history branch from e2f32ac to b0cff73 Compare October 30, 2023 19:36
@valenad1 valenad1 removed the request for review from michalkurka October 30, 2023 19:38
@valenad1 valenad1 force-pushed the valenad-eif-scoring-history-score-according-computing-time branch from 52bcfd9 to 3a4defa Compare October 30, 2023 19:40
@valenad1 valenad1 force-pushed the valenad-eif-scoring-history-score-according-computing-time branch from 3a4defa to 3efa155 Compare November 9, 2023 16:39
@maurever maurever self-requested a review November 14, 2023 08:25
maurever
maurever previously approved these changes Nov 14, 2023
@valenad1 valenad1 force-pushed the valenad-eif-scoring-history-score-according-computing-time branch 2 times, most recently from d71fc23 to a6e282f Compare November 16, 2023 17:06
@valenad1 valenad1 changed the title PUBDEV-8547 - score eif accoring to computing time settings GH-7118 - score eif accoring to computing time settings Nov 20, 2023
Base automatically changed from valenad-eif-scoring-history to rel-3.44.0 November 20, 2023 12:54
@valenad1 valenad1 dismissed maurever’s stale review November 20, 2023 12:54

The base branch was changed.

@valenad1 valenad1 force-pushed the valenad-eif-scoring-history-score-according-computing-time branch from a6e282f to 0c784a0 Compare November 20, 2023 13:03
@valenad1 valenad1 requested a review from maurever November 20, 2023 13:05
maurever
maurever previously approved these changes Nov 20, 2023
@valenad1 valenad1 added this to the 3.44.0.3 milestone Nov 20, 2023
@valenad1 valenad1 merged commit f797841 into rel-3.44.0 Nov 21, 2023
2 checks passed
@valenad1 valenad1 deleted the valenad-eif-scoring-history-score-according-computing-time branch November 21, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants