Removed importing urllib3

h2oai · Mar 21, 2024 · 81d5de4 · 81d5de4
1 parent a1a0cbb
commit 81d5de4
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/py/Makefile b/py/Makefile
@@ -38,7 +38,7 @@ setup-tests: ## Install dependencies for tests only
 	python3 -m venv venv
 	echo "# Generated in hatch_build.py\n__platform__ = 'linux'\n__arch__ = 'amd64'" > h2o_wave/h2o_wave/metadata.py
 	./venv/bin/python -m pip install --editable h2o_wave
-	./venv/bin/pip install httpx urllib3 typing_extensions
+	./venv/bin/pip install httpx typing_extensions
 
 .PHONY: docs
 docs: ## Build API docs

diff --git a/py/tests/__main__.py b/py/tests/__main__.py
@@ -6,9 +6,6 @@
 import os
 import platform
 
-# HACK: Use urllib3 import side-effect to resolve "ResourceWarning: unclosed transport" in python>=3.9 versions.
-import urllib3
-
 from .test_expando import *
 from .test_python_server import *
 from .test_python_server_async import *

diff --git a/setup.ps1 b/setup.ps1
@@ -11,7 +11,7 @@ Set-Location py
 python -m venv venv
 .\venv\Scripts\python -m pip install --upgrade pip
 .\venv\Scripts\python -m pip install --editable h2o_wave
-.\venv\Scripts\pip install httpx urllib3 typing_extensions
+.\venv\Scripts\pip install httpx typing_extensions
 echo "# Generated in hatch_build.py\n__platform__ = 'linux'\n__arch__ = 'amd64'" > h2o_wave/h2o_wave/metadata.py
 if ($LastExitCode -ne 0) { exit $LastExitCode }