HFP-3645 Fix calls to showSolutions or resetTask #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otacke
changed the title
|
Fixed by #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when Multiple Choice questions are subcontent and the parent content does not attach Multiple Choice content when instantiating, but dynamically as needed like Interactive Book, calls to the Question Type contract functions
showSolutionsandresetTaskwill crash Multiple Choice. That's because Multiple Choice assumes that it's DOM elements have already been attached to the page, but doesn't check.When merged in, a guard will be added to the
showSolutionsfunction and theresetTaskfunction to prevent crashes.