Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Obsolete / Dead Code #1866

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

jasonheath
Copy link
Contributor

This removes obsolete components and dead code.

Code removal was equivalent to the following:

  • git rm -r components/builder-graph
  • git rm -r components/builder-jobsrv
  • git rm -r components/builder-worker
  • git rm -r components/builder-api/habitat-dev
  • git rm -r components/builder-api-proxy/habitat-dev

After that the top level Cargo.toml was updated to remove the graph, jobsrv, and worker components which dropped a lot of dependencies and restored basic cargo functionality. Then broad review of the code base started in order to remove or modify items as appropriate for the removal of these items as well as anything else that was identified as obsolete.

Code removal was equivalent to the following:
- git rm -r components/builder-graph
- git rm -r components/builder-jobsrv
- git rm -r components/builder-worker
- git rm -r components/builder-api/habitat-dev
- git rm -r components/builder-api-proxy/habitat-dev

After that the top level Cargo.toml was updated to remove the graph,
jobsrv, and worker components which dropped a lot of dependencies
and restored basic cargo functionality.

Signed-off-by: Jason Heath <[email protected]>
Signed-off-by: Jason Heath <[email protected]>
Signed-off-by: Jason Heath <[email protected]>
@jasonheath
Copy link
Contributor Author

jasonheath commented Jan 29, 2025

The commits so far all shake out from the initial mandate of dropping the graph, jobsrv, and worker components and the code still compiles via cargo build. I've intentionally stayed out of the rust code so far but some amount of review is due there to cut out dead code. The idea be to commit now and see how we far under buildkite at this point.

Beyond changes that shake out from this first push and the subsequent rust changes in the remaining components at least the following items feel as work to be done.

  • Both DEVELOPING.md and RELEASE.md deserve review and revision.
  • Does anything need to be dropped from the DB?
  • Does anything need to be dropped from the protobufs?
  • Does anything need to be removed from the Builder HTTP API?
  • What follow on may be appropriate for on-prem-builder?
  • Terraform needs review and updated.

The first five feel like appropriate considerations for this current round of work.

As for on-prem-builder follow on we've deleted a couple of scripts here that I think are mirrored there. Removing those, reviewing for similar, and formally testing that our scripting works as expected may be it. There is one reference to jobsrv in provision.sh that I see but I haven't looked closely at it yet. This work feels small.

Updating our Terraform scripts is probably best suited as a planned item for a future PI as it may involve another team or be handed off to another team altogether. This work feels large or x-large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant