-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using rustls-0.23 and related dependencies #9552
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy Preview for chef-habitat processing.
|
Signed-off-by: Abhijit Gadgil <[email protected]>
Signed-off-by: Abhijit Gadgil <[email protected]>
Signed-off-by: Abhijit Gadgil <[email protected]>
ea78e99
to
f57350d
Compare
Signed-off-by: Abhijit Gadgil <[email protected]>
f57350d
to
4e71c7e
Compare
Signed-off-by: Matt Wrock <[email protected]>
Signed-off-by: Abhijit Gadgil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. There are a couple small things I commented on.
let tls_config = TlsClientConfig::builder().with_safe_defaults() | ||
.with_root_certificates(server_certificates); | ||
if let Some(client_key) = client_key { | ||
let tls_config = TlsClientConfig::builder() //.with_safe_default_protocol_versions() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to remove this?
@@ -30,7 +30,7 @@ pin-project = "*" | |||
rand = "*" | |||
regex = "*" | |||
rcgen = "*" | |||
rustls = "*" | |||
rustls = "0.23" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we keep this a *?
No description provided.