Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using rustls-0.23 and related dependencies #9552

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

agadgil-progress
Copy link
Contributor

No description provided.

@agadgil-progress agadgil-progress marked this pull request as draft January 7, 2025 09:59
Copy link

netlify bot commented Jan 7, 2025

👷 Deploy Preview for chef-habitat processing.

Name Link
🔨 Latest commit b40dc6f
🔍 Latest deploy log https://app.netlify.com/sites/chef-habitat/deploys/67931586b7da8a00083c568b

@agadgil-progress agadgil-progress force-pushed the agadgil/rustls-023 branch 2 times, most recently from ea78e99 to f57350d Compare January 22, 2025 09:54
mwrock and others added 2 commits January 23, 2025 11:58
Copy link
Contributor

@mwrock mwrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. There are a couple small things I commented on.

let tls_config = TlsClientConfig::builder().with_safe_defaults()
.with_root_certificates(server_certificates);
if let Some(client_key) = client_key {
let tls_config = TlsClientConfig::builder() //.with_safe_default_protocol_versions()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to remove this?

@@ -30,7 +30,7 @@ pin-project = "*"
rand = "*"
regex = "*"
rcgen = "*"
rustls = "*"
rustls = "0.23"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep this a *?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants