Added shop details #1044
Added shop details #1044
Conversation
BudzioT
requested review from
malted,
maxwofford and
polytroper
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Also made project shipping confirmation a little bigger, it depends on vh now instead of strict pixels |
|
Approved by Nora on Slack, so @malted or @maxwofford feel free to merge it if you want |
|
Hey! Sorry for missing this. Happy to merge if you resolve the conflicts @BudzioT |
|
@maxwofford |
| @@ -116,7 +196,7 @@ export const ShopItemComponent = ({ | |||
| height={20} | |||
| className="mr-1" | |||
| /> | |||
| {localPrice} | |||
There was a problem hiding this comment.
Did you mean to remove this?
There was a problem hiding this comment.
Changed it earlier to {filterIndex == 1 ? item.priceUs : item.priceGlobal} idk why, but reverted now
| @@ -10,10 +10,12 @@ import { | |||
| CardTitle, | |||
| } from '@/components/ui/card' | |||
| import { Button } from '@/components/ui/button' | |||
| import { useMemo } from 'react' | |||
| import React, { useMemo, useState } from 'react' | |||
There was a problem hiding this comment.
Do we need the React import?
There was a problem hiding this comment.
Webstorm playing tricks again... fixed
|
@maxwofford should be better now |
Many people are confused about details of items, with this we can change that. I know Nora was working on it, but even if she began, we can temporarely merge that or for a longer time (depending on how well it is made).
Just click on an item and you can see its details (it doesn't affect buy and favourite button!)
I can manually edit more descriptions of items, if you feel like this isn't too fun, or we can wait for Nora to do it.
It works on different regions and gives accurate links based on them, also doesn't show info about customs if US is selected.
Some examples of items are here:
