Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ability to ship local files as a demo #1119

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −0
Open

Remove the ability to ship local files as a demo #1119

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e15c66
Remove the ability to ship local files as a demo
scooterthedev Jan 20, 2025
9503c95
Trying to fix the fomatting
scooterthedev Jan 20, 2025
28458b8
Actually ran prettier now
scooterthedev Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/app/harbor/shipyard/new-ship-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,16 @@ export default function NewShipForm({
return
}

if (deploymentUrl.startsWith('file://')) {
toast({
title: "Local file URLs aren't allowed",
description:
'You cannot use a local file as a demo. Try using #cdn instead to host a video or vercel for a deployed project!',
})
setStaging(false)
return
}

const repoUrl = formData.get('repo_url') as string
if (usedRepos.includes(repoUrl)) {
toast({
Expand Down
Loading