Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

won't restart the tutorial if user has already done it and it is on t… #769

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

cskartikey
Copy link
Member

…he server side

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
high-seas ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 4:57pm

@malted
Copy link
Member

malted commented Nov 14, 2024

What does this fix that the below doesn't do?

useEffect(() => {
    let academyCompleted

    try {
      academyCompleted = JSON.parse(Cookies.get('academy-completed'))
    } catch (e) {
      console.error(e)
      academyCompleted = false
    }

    if (!academyCompleted) {
      tour()
    }
  }, [])

@cskartikey
Copy link
Member Author

cskartikey commented Nov 14, 2024

I don't see academy-completed cookie anywhere in my application storage.

@cskartikey cskartikey merged commit 36d8ffc into main Nov 15, 2024
2 of 3 checks passed
@cskartikey cskartikey deleted the tour-fix branch November 15, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants