Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typescript): disable exactOptionalPropertyTypes #1150

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

dhess
Copy link
Member

@dhess dhess commented Apr 10, 2024

This setting is causing problems for us with one package we'd like to use:

#1012 (comment)

and is also preventing us from migrating to TypeScript 5 due to an upstream issue in react-router that's been unaddressed for almost a year:

#898

There were no objections to disabling it, so we do so in this commit. (There is one minor code change required as a result, just an additional optional property check on a onNodeClick handler in our React Flow wrapper.)

Closes #898

This setting is causing problems for us with one package we'd like to
use:

#1012 (comment)

and is also preventing us from migrating to TypeScript 5 due to an
upstream issue in `react-router` that's been unaddressed for almost a
year:

#898

There were no objections to disabling it, so we do so in this commit.
(There is one minor code change required as a result, just an
additional optional property check on a `onNodeClick` handler in our
React Flow wrapper.)

Closes #898

Signed-off-by: Drew Hess <[email protected]>
@dhess dhess enabled auto-merge April 10, 2024 09:29
@dhess dhess added this pull request to the merge queue Apr 10, 2024
Merged via the queue into main with commit 553e0a6 Apr 10, 2024
32 of 33 checks passed
@dhess dhess deleted the dhess/exactproperties branch April 10, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream issue preventing migration to TypeScript 5.x
1 participant