-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify resclust outputs #330
Open
VGPReys
wants to merge
15
commits into
haddocking:main
Choose a base branch
from
VGPReys:resclust-outputs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
08e89e5
issue #327
VGPReys 0de5dad
lint and review fixes
VGPReys dd67e33
filenames & ext
VGPReys ce3ecae
Carriage return issue in .out file
VGPReys 6b1c0ee
Merge branch 'main' into resclust-outputs
VGPReys 58e0fef
Merge branch 'main' into resclust-outputs
VGPReys 1094bad
Update clustering.py
VGPReys 999cdff
Update cli_resclust.py
VGPReys bce2c1a
Update test_cli_resclust.py
VGPReys 2f883e6
Update test_clustering.py
VGPReys ddf78ec
Merge branch 'main' into resclust-outputs
mgiulini a776885
update ci.yml
rvhonorato 9538941
Merge branch 'main' into resclust-outputs
VGPReys 2cc1c75
update logic in addition of ligand in cluster dict
VGPReys 7dd88ec
Update clustering.py
VGPReys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will change the type of the key from integer to string and can have breaking consequences, why not use integers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the point of the PR, integer as keys cannot be loaded using the
json
library.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is the default behaviour of json.load, casting the type into it needs you to reclass a Decoder