all: bring back NSInvocation for CopyFromTexture #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial revert of c3ea539 but keeps the change for removal of NSInvocation in SetScissorRect, GetBytes, and ReplaceRegion. Closes hajimehoshi#3135
hajimehoshi
reviewed
Oct 19, 2024
go.mod
Outdated
| @@ -6,7 +6,7 @@ require ( | |||
| github.com/ebitengine/gomobile v0.0.0-20241016134836-cc2e38a7c0ee | |||
| github.com/ebitengine/hideconsole v1.0.0 | |||
| github.com/ebitengine/oto/v3 v3.4.0-alpha.1 | |||
| github.com/ebitengine/purego v0.9.0-alpha.0.20241018101553-999f588e4548 | |||
| github.com/ebitengine/purego v0.9.0-alpha.0.20241019141807-abe9f9ad3f22 | |||
There was a problem hiding this comment.
This is already updated. Please merge or rebase the main branch.
|
I've confirmed your PR worked on my local machine! |
TotallyGamerJet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
Closes #3135
What type of issue is this addressing?
bug
What this PR does | solves
This is a partial revert of c3ea539 but keeps the change for removal of NSInvocation in SetScissorRect, GetBytes, and ReplaceRegion.