Skip to content

Commit

Permalink
Drop support for Python 3.8
Browse files Browse the repository at this point in the history
  • Loading branch information
hajimes committed Jan 23, 2025
1 parent c290d82 commit 197c7a2
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
strategy:
matrix:
os: [macOS-14, windows-2022, ubuntu-22.04]
python-version: [3.8, 3.9, "3.10", "3.11", "3.12"]
python-version: [3.9, "3.10", "3.11", "3.12"]

runs-on: ${{ matrix.os }}
steps:
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,12 @@ jobs:
with:
output-dir: wheelhouse
env:
CIBW_BUILD: "{cp38,cp39,cp310,cp311,cp312,cp313}-${{ matrix.build }}*"
CIBW_SKIP: cp38-win_arm64
CIBW_BUILD: "{cp39,cp310,cp311,cp312,cp313}-${{ matrix.build }}*"
CIBW_ARCHS: ${{ matrix.archs }}
CIBW_BUILD_FRONTEND: "build"
CIBW_TEST_REQUIRES: "pytest"
CIBW_TEST_COMMAND: "pytest {project}"
CIBW_TEST_SKIP: "*-win_arm64 cp38-macosx_*:arm64"
CIBW_TEST_SKIP: "*-win_arm64"
- uses: actions/upload-artifact@v4
with:
name: Wheel-${{ matrix.os }}-${{ matrix.build }}${{ matrix.archs }}
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ since version 3.0.0.
- Improve the performance of `hash128()`, `hash64()`, and `hash_bytes()`
by using METH_FASTCALL, reducing the overhead of function calls.

### Removed

- Drop support for Python 3.8, as it has reached the end of life on 2024-10-07.

## [5.0.1] - 2024-09-22

### Fixed
Expand Down
3 changes: 1 addition & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ description = "Python extension for MurmurHash (MurmurHash3), a set of fast and
readme = "README.md"
license = {file = "LICENSE"}
keywords = ["utility", "hash", "MurmurHash"]
requires-python = ">=3.8"
requires-python = ">=3.9"
authors = [
{name = "Hajime Senuma", email="[email protected]"}
]
Expand All @@ -19,7 +19,6 @@ classifiers = [
"Intended Audience :: Developers",
"License :: OSI Approved :: MIT License",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down
3 changes: 0 additions & 3 deletions src/mmh3/__init__.pyi
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# to use list, tuple, dict ... in Python 3.7 and 3.8
from __future__ import annotations

import sys
from typing import Any, Union, final

Expand Down
10 changes: 5 additions & 5 deletions util/refresh.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# pylint: disable=missing-function-docstring
"""A script to generate Murmurhash3 C files from the original C++ source."""

from __future__ import annotations

import os
import re
import textwrap
Expand Down Expand Up @@ -656,9 +654,11 @@ def lowercase_function_names(subcode: str) -> str:
new_header_path = os.path.join(dir_path, "../src/mmh3", NEW_HEADER_NAME)
file_header_path = os.path.join(dir_path, FILE_HEADER_NAME)

with open(original_source_path, "r", encoding="utf-8") as source_file, open(
original_header_path, "r", encoding="utf-8"
) as header_file, open(file_header_path, "r", encoding="utf-8") as file_header_file:
with (
open(original_source_path, "r", encoding="utf-8") as source_file,
open(original_header_path, "r", encoding="utf-8") as header_file,
open(file_header_path, "r", encoding="utf-8") as file_header_file,
):
source = MMH3Source(source_file.read())
header = MMH3Header(header_file.read())
file_header = file_header_file.read()
Expand Down

0 comments on commit 197c7a2

Please sign in to comment.